mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Date Thu, 19 Mar 2020 13:15:37 GMT


> On March 19, 2020, 10:47 a.m., Qian Zhang wrote:
> > src/master/validation.cpp
> > Lines 2073 (patched)
> > <https://reviews.apache.org/r/72216/diff/5/?file=2214199#file2214199line2073>
> >
> >     I think we should not check all tasks of the framework, instead we should only
check the tasks launched by the same executor on this specific slave for this specific framework.
Maybe we should go through `slave->tasks.at(framework.id())` and check each task launched
by the same executor. Or we could do this validation in Mesos agent?

Whoops sorry, I had that check in before and lost it while I was refactoring :facepalm:


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72216/#review219999
-----------------------------------------------------------


On March 19, 2020, 1:14 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72216/
> -----------------------------------------------------------
> 
> (Updated March 19, 2020, 1:14 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10045
>     https://issues.apache.org/jira/browse/MESOS-10045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added master validation for task resource limits and shared cgroups.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 
> 
> 
> Diff: https://reviews.apache.org/r/72216/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message