mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Date Wed, 18 Mar 2020 03:30:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71983/#review219979
-----------------------------------------------------------




src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 900-902 (patched)
<https://reviews.apache.org/r/71983/#comment308208>

    This could be racy; the expectation will be violated if we get another offer before the
next `EXPECT_CALL(*scheduler, offers(_, _))`. We should either pause the clock and manually
advance it to trigger offers (preferred), or add a `.WillRepeatedly(Return());` to this expectation.


- Greg Mann


On March 18, 2020, 2:01 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71983/
> -----------------------------------------------------------
> 
> (Updated March 18, 2020, 2:01 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10050
>     https://issues.apache.org/jira/browse/MESOS-10050
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e

> 
> 
> Diff: https://reviews.apache.org/r/71983/diff/6/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message