mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Date Wed, 18 Mar 2020 03:17:50 GMT


> On March 16, 2020, 11:54 a.m., Greg Mann wrote:
> > src/docker/executor.cpp
> > Lines 201-212 (original), 201-212 (patched)
> > <https://reviews.apache.org/r/72022/diff/4/?file=2214052#file2214052line201>
> >
> >     We also have the less common case of a custom executor in a Docker container
in `DockerContainerizerProcess::launchExecutorContainer()`, found in the file 'src/slave/containerizer/docker.cpp'.
We should probably pass limits through there as well?
> 
> Qian Zhang wrote:
>     Yes, we should. Actually that is the scope of https://issues.apache.org/jira/browse/MESOS-10054
, and I think we can do it in a separate patch rather than in this patch. And as you mentioned
it is a less common case, so I think we could do it post MVP, HDYT?

sgtm


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72022/#review219953
-----------------------------------------------------------


On March 16, 2020, 9:16 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72022/
> -----------------------------------------------------------
> 
> (Updated March 16, 2020, 9:16 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
>     https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set resource limits and OOM score adjustment in Docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp b48d894ed59170849f4b4ac5e37842af6c421e81 
>   src/docker/docker.cpp 04fb8d0ffbbfb9d10dd39a7b49a37f6e8c751bfd 
>   src/docker/executor.cpp ebbbc0df043d1bf4b0712e4130a24abdfa5eb107 
> 
> 
> Diff: https://reviews.apache.org/r/72022/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message