mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Date Mon, 16 Mar 2020 08:09:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72222/#review219947
-----------------------------------------------------------



Bad review!

Reviews applied: [72222, 72221, 72217, 72216, 71955, 71953, 71952, 71951, 71950, 71944, 71943,
71886, 71885, 71884, 71858, 72162, 72161]

Error:
2020-03-16 08:14:33 URL:https://reviews.apache.org/r/71884/diff/raw/ [29892/29892] -> "71884.patch"
[1]
error: patch failed: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp:812
error: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp: patch does not apply

- Mesos Reviewbot


On March 12, 2020, 4:13 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72222/
> -----------------------------------------------------------
> 
> (Updated March 12, 2020, 4:13 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10045
>     https://issues.apache.org/jira/browse/MESOS-10045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds validation for shared cgroups when specified
> via the agent APIs. In doing so, a new validation test is
> added for the agent's LaunchContainer API, since this was
> previously missing.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_validation_tests.cpp 25019ccdc34db35770b0f69301b94e38636059b7 
> 
> 
> Diff: https://reviews.apache.org/r/72222/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message