mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72233: Fixed undefined behavior in ActionObject::reserve.
Date Fri, 13 Mar 2020 10:06:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72233/#review219934
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Sekretenko


On March 12, 2020, 10 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72233/
> -----------------------------------------------------------
> 
> (Updated March 12, 2020, 10 p.m.)
> 
> 
> Review request for mesos and Andrei Sekretenko.
> 
> 
> Bugs: MESOS-10103
>     https://issues.apache.org/jira/browse/MESOS-10103
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Found by Andrei Sekretenko using -fsanitize=address, the following
> expression has an intermediate temporary!
> 
>   const RepeatedPtrField<Resource::ReservationInfo>&
>     ancestorReservations =
>     RepeatedPtrField<Resource>(ancestor).begin()->reservations();
> 
> Therefore, the intermediate temporary will not have its lifetime
> extended and this is undefined behavior which leads to a crash
> in the windows CI.
> 
> 
> Diffs
> -----
> 
>   src/master/authorization.cpp 6dfa59ad621d9aa0fd1dbbdbe4fa8965e413774f 
> 
> 
> Diff: https://reviews.apache.org/r/72233/diff/1/
> 
> 
> Testing
> -------
> 
> Ran through windows CI.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message