mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`.
Date Thu, 12 Mar 2020 13:24:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72189/#review219920
-----------------------------------------------------------



In commit message: s/shared_cgroups/share_cgroups/

- Greg Mann


On March 4, 2020, 10:56 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72189/
> -----------------------------------------------------------
> 
> (Updated March 4, 2020, 10:56 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Parametrized some `NestedMesosContainerizerTest` tests on whether we
> are launching nested containers with `shared_cgroups=false` or not.
> Previously, all nested containers shared cgroups with their parent by
> default. Now, since we've added support for nested containers with
> their own cgroups, we need to verify that a nested container with
> `shared_cgroups=false` can be successfully launched and it does not
> lead to errors during the recovery of Mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp c6f96e6b1bc0d9989ca87d23e112604820ac1d51

> 
> 
> Diff: https://reviews.apache.org/r/72189/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message