mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Date Wed, 11 Mar 2020 09:41:55 GMT


> On March 6, 2020, 4:06 p.m., Greg Mann wrote:
> > src/docker/docker.cpp
> > Lines 685 (patched)
> > <https://reviews.apache.org/r/72022/diff/2/?file=2212187#file2212187line685>
> >
> >     Is it not possible for us to handle infinite limits here?

For infinite limits, we actually do not need to handle them, then the corresponding Docker
options will not be set when we run `docker run` which means unlimited resource limits. I
will add a comment here to explain this.


> On March 6, 2020, 4:06 p.m., Greg Mann wrote:
> > src/docker/docker.cpp
> > Line 663 (original), 714-716 (patched)
> > <https://reviews.apache.org/r/72022/diff/2/?file=2212187#file2212187line714>
> >
> >     Do we want to set the memory reservation here as well?

I do not think we want to do that because of backward compatibility.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72022/#review219816
-----------------------------------------------------------


On March 11, 2020, 5:41 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72022/
> -----------------------------------------------------------
> 
> (Updated March 11, 2020, 5:41 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
>     https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set resource limits and OOM score adjustment in Docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp b48d894ed59170849f4b4ac5e37842af6c421e81 
>   src/docker/docker.cpp 04fb8d0ffbbfb9d10dd39a7b49a37f6e8c751bfd 
>   src/docker/executor.cpp ebbbc0df043d1bf4b0712e4130a24abdfa5eb107 
> 
> 
> Diff: https://reviews.apache.org/r/72022/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message