mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.
Date Wed, 11 Mar 2020 07:49:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71955/#review219878
-----------------------------------------------------------




src/tests/mesos.hpp
Lines 105 (patched)
<https://reviews.apache.org/r/71955/#comment308121>

    We always use fully-qualified names in headers; could you remove this `using` directive?


- Greg Mann


On March 10, 2020, 8:50 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71955/
> -----------------------------------------------------------
> 
> (Updated March 10, 2020, 8:50 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10047
>     https://issues.apache.org/jira/browse/MESOS-10047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new parameter `resourceLimits` to the `createTask` methods.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 17fcaa3eff28e8139e6770629a5dfbb7c29289ec 
> 
> 
> Diff: https://reviews.apache.org/r/71955/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message