mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Date Tue, 10 Mar 2020 09:43:41 GMT


> On March 9, 2020, 9:35 p.m., Andrei Budnik wrote:
> > src/master/validation.cpp
> > Lines 1991 (patched)
> > <https://reviews.apache.org/r/72216/diff/1/?file=2213311#file2213311line1991>
> >
> >     `shareCgroups` can be initialized with the value taken from the first task within
a task group. This may simplify the `foreach` loop. Also, this would allow us to move `if
(currentShareCgroups && !task.limits().empty` check outside the loop.

I ended up moving the share_cgroups validation to the `validateTask()` function which is used
for task group tasks, let me know what you think.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72216/#review219855
-----------------------------------------------------------


On March 10, 2020, 9:42 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72216/
> -----------------------------------------------------------
> 
> (Updated March 10, 2020, 9:42 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10045
>     https://issues.apache.org/jira/browse/MESOS-10045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added master validation for task resource limits and shared cgroups.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 
> 
> 
> Diff: https://reviews.apache.org/r/72216/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message