mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Date Sun, 08 Mar 2020 14:29:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71965/#review219836
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Line 411 (original), 412 (patched)
<https://reviews.apache.org/r/71965/#comment308078>

    s/with/from/



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Line 735 (original)
<https://reviews.apache.org/r/71965/#comment308081>

    Why do you remove this? Can we change it to `const string& cgroup = info->cgroup;`?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 743-748 (original), 758-762 (patched)
<https://reviews.apache.org/r/71965/#comment308082>

    I think this is for the case: Agent is started with a cgroup subsystem specified (like
`--isolation=cgroups/cpu`) and a default executor is launched to run a task group with `share_cgroups==true`,
now agent is restarted with two cgroup subsystems (like `--isolation=cgroups/cpu,cgroups/mem`)
and another task group with `share_cgroups==true` is launched by the same default executor.
For the nested containers corresponding to the second task group, we should NOT assign their
pids for the subsystem `cgroups/mem` since the default executor does not have cgroup created
under it.
    
    So I think we should not change the log message here.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 1058-1072 (patched)
<https://reviews.apache.org/r/71965/#comment308080>

    It seems the `while` loop will be an endless loop if the input `containerId` is an ID
of an unknown container (because `current.isSome()` is always true).


- Qian Zhang


On Feb. 14, 2020, 1:19 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71965/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2020, 1:19 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Qian Zhang.
> 
> 
> Bugs: MESOS-10076
>     https://issues.apache.org/jira/browse/MESOS-10076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds support for nested cgroups for nested containers.
> Nested cgroups are created only for a nested container with explicitly
> enabled `share_cgroups` flag. The cgroups isolator stores info about
> nested cgroups in the `infos` class variable, which is used to
> determine whether a nested container has its nested cgroup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 4bd3d6dad37dee031660c15e957cc36f63e21fcb

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e

> 
> 
> Diff: https://reviews.apache.org/r/71965/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message