mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72208: Ensured that MasterAPITest.ReservationUpdate waits for changes on agent.
Date Sat, 07 Mar 2020 05:01:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72208/#review219833
-----------------------------------------------------------



Bad review!

Reviews applied: [72208]

Error:
2020-03-07 05:01:18 URL:https://reviews.apache.org/r/72208/diff/raw/ [1317/1317] -> "72208.patch"
[1]
error: patch failed: src/tests/api_tests.cpp:1495
error: src/tests/api_tests.cpp: patch does not apply

- Mesos Reviewbot


On March 6, 2020, 6:41 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72208/
> -----------------------------------------------------------
> 
> (Updated March 6, 2020, 6:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10102
>     https://issues.apache.org/jira/browse/MESOS-10102
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes flakiness in this test by making sure that,
> before checking agent state via agent API, not only RESERVE_RESOURCES
> call of master V1 API returns, but also the agent completes processing
> messages from master.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp d1368a74f0ab51ed9824bba1ddf0b7135a1d06a7 
> 
> 
> Diff: https://reviews.apache.org/r/72208/diff/1/
> 
> 
> Testing
> -------
> 
> `./bin/mesos-tests.sh --gtest_filter="*ReservationUpdate*" --gtest_repeat=10000 --gtest_break_on_failure
--verbose` on a heavily loaded machine
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message