mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72201: Fixed the broken PathTest.Relative on Windows.
Date Fri, 06 Mar 2020 15:25:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72201/#review219827
-----------------------------------------------------------


Ship it!





3rdparty/stout/tests/path_tests.cpp
Lines 359-379 (patched)
<https://reviews.apache.org/r/72201/#comment308056>

    If I'm not missing something, Windows still has an ability to use different disk designators
("C:", "D:" and so on) and also the alternative form of relative path("C:tempdir\tmp.txt").
    
    Do you know if we have tests for them/are we planning to test for them/do we actually
support them?


- Andrei Sekretenko


On March 5, 2020, 11:11 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72201/
> -----------------------------------------------------------
> 
> (Updated March 5, 2020, 11:11 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Joseph Wu.
> 
> 
> Bugs: MESOS-10100
>     https://issues.apache.org/jira/browse/MESOS-10100
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test uses only linux style paths and fails on windows. This
> happened because this code was introduced recently but there was
> no testing or CI running on windows to catch it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/path_tests.cpp d418d1b53886042400365d32f7999e84059911c3 
> 
> 
> Diff: https://reviews.apache.org/r/72201/diff/1/
> 
> 
> Testing
> -------
> 
> Ran through a windows CI.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message