mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Date Fri, 06 Mar 2020 12:53:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72041/#review219824
-----------------------------------------------------------


Fix it, then Ship it!





src/launcher/default_executor.cpp
Lines 492-495 (patched)
<https://reviews.apache.org/r/72041/#comment308055>

    Should we add a TODO here for specifying disk resources on the task containers and mounting
them in the task containers directly?


- Greg Mann


On March 5, 2020, 1:02 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72041/
> -----------------------------------------------------------
> 
> (Updated March 5, 2020, 1:02 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10063
>     https://issues.apache.org/jira/browse/MESOS-10063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated default executor to call the `LaunchContainer` agent API.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp b431d8f86a359d64f84ea1c5fae63ee6cbddba31 
> 
> 
> Diff: https://reviews.apache.org/r/72041/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message