mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Date Fri, 06 Mar 2020 12:49:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72040/#review219823
-----------------------------------------------------------


Ship it!




LGTM, modulo the addition of validation which makes it safe to allow the specification of
resources on nested containers. Could you update the description to note that this validation
will be added in a subsequent patch? (I'll submit one soon)

- Greg Mann


On Jan. 23, 2020, 1:12 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72040/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2020, 1:12 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10051
>     https://issues.apache.org/jira/browse/MESOS-10051
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the `LaunchContainer` agent API to support resource limits.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 030ed61af3c3864c2b9a63f91c37419745c8d57d 
>   include/mesos/v1/agent/agent.proto be7db868b2fed961c34db6e5fb1193e310ea8991 
>   src/slave/http.hpp 0afdad9479f0cc2c94452b6b1f2289dd6ea01494 
>   src/slave/http.cpp 04ad0d816618a1880913857a6f0ff38c4643c488 
>   src/slave/validation.cpp 99b17c965d4cc522e9106078a9e6f34fae396b8a 
> 
> 
> Diff: https://reviews.apache.org/r/72040/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message