mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CgroupsEnableCFS`.
Date Fri, 06 Mar 2020 12:44:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72027/#review219821
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4325 (patched)
<https://reviews.apache.org/r/72027/#comment308051>

    Agent is using all of the host memory right?



src/tests/containerizer/docker_containerizer_tests.cpp
Lines 4440 (patched)
<https://reviews.apache.org/r/72027/#comment308052>

    Could you use CPU_SHARES_PER_CPU here instead of the literal?


- Greg Mann


On Jan. 20, 2020, 8:58 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72027/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2020, 8:58 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
>     https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new test `ROOT_DOCKER_CGROUPS_CFS_CgroupsEnableCFS`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 689a7220a09f2a58dffdf0dc9fd9f0548600be0e

> 
> 
> Diff: https://reviews.apache.org/r/72027/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message