mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Date Fri, 06 Mar 2020 08:06:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72022/#review219816
-----------------------------------------------------------




src/docker/docker.hpp
Line 190 (original), 190-191 (patched)
<https://reviews.apache.org/r/72022/#comment308044>

    Do we need the NOLINT here?
    ```
            const Option<mesos::internal::ContainerDNSInfo>&
              defaultContainerDNS = None(),
            const Option<google::protobuf::Map<std::string, mesos::Value::Scalar>>&
              resourceLimits = None());
    ```



src/docker/docker.cpp
Lines 685 (patched)
<https://reviews.apache.org/r/72022/#comment308047>

    Is it not possible for us to handle infinite limits here?



src/docker/docker.cpp
Lines 711 (patched)
<https://reviews.apache.org/r/72022/#comment308045>

    Can we factor this out into a helper function so that we don't have this magic formula
hard-coded in two places?



src/docker/docker.cpp
Line 663 (original), 714-716 (patched)
<https://reviews.apache.org/r/72022/#comment308046>

    Do we want to set the memory reservation here as well?


- Greg Mann


On Feb. 26, 2020, 12:24 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72022/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2020, 12:24 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
>     https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set resource limits and OOM score adjustment in Docker executor.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp b48d894ed59170849f4b4ac5e37842af6c421e81 
>   src/docker/docker.cpp 04fb8d0ffbbfb9d10dd39a7b49a37f6e8c751bfd 
>   src/docker/executor.cpp ebbbc0df043d1bf4b0712e4130a24abdfa5eb107 
> 
> 
> Diff: https://reviews.apache.org/r/72022/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message