mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72161: Added patch for RapidJSON.
Date Fri, 06 Mar 2020 01:42:55 GMT


> On Feb. 28, 2020, 12:59 a.m., Benjamin Bannier wrote:
> > Is the plan to upstream this patch? We usually try to enable building against unbundled
dependencies and depending on custom behavior makes that impossible. My hunch would be to
not make functional changes like the one in this patch to dependencies (changes for building
are usually fine).
> 
> Greg Mann wrote:
>     Yea, attempting to upstream is a good idea. Qian would you like to open a PR, or
would you like me to? https://github.com/Tencent/rapidjson

I am not sure if it is something which will be accepted by upstream, what I did in this patch
is to make RapidJSON confirm to the rule defined by ProtoBuf (https://developers.google.com/protocol-buffers/docs/proto3#json),
I am not sure if that is a general rule that RapidJSON will care about.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72161/#review219677
-----------------------------------------------------------


On March 2, 2020, 2:27 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72161/
> -----------------------------------------------------------
> 
> (Updated March 2, 2020, 2:27 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10064
>     https://issues.apache.org/jira/browse/MESOS-10064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit updates the writer of RapidJSON to write infinite
> floating point numbers as "Infinity" and "-Infinity" (i.e.,
> with double quotes) rather than Infinity and -Infinity. This
> is to ensure the strings converted from JSON objects conform
> to the rule defined by Protobuf:
> https://developers.google.com/protocol-buffers/docs/proto3#json
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt c45d742684ba4b3b4abc57ae0bcb85a879c68bfd 
>   3rdparty/rapidjson-1.1.0.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72161/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message