mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Date Thu, 05 Mar 2020 17:44:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71956/#review219803
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 527 (patched)
<https://reviews.apache.org/r/71956/#comment308033>

    Isn't the agent here currently using all of the host memory?


- Greg Mann


On Jan. 15, 2020, 2:24 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71956/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2020, 2:24 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10047
>     https://issues.apache.org/jira/browse/MESOS-10047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e

> 
> 
> Diff: https://reviews.apache.org/r/71956/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message