mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Date Thu, 05 Mar 2020 15:56:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71953/#review219798
-----------------------------------------------------------




src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 474 (patched)
<https://reviews.apache.org/r/71953/#comment308030>

    Instead of using `path::join()`, is there a cgroup helper function we can use to get this
path?



src/tests/containerizer/cgroups_isolator_tests.cpp
Lines 489-496 (patched)
<https://reviews.apache.org/r/71953/#comment308029>

    Does it make sense to put this part in either the 'MemoryForward' or 'MemoryBackward'
tests, instead of here? Or to create a new test which verifies basic memory isolator behavior?


- Greg Mann


On Jan. 15, 2020, 2:24 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71953/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2020, 2:24 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10047
>     https://issues.apache.org/jira/browse/MESOS-10047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e

> 
> 
> Diff: https://reviews.apache.org/r/71953/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message