mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Date Thu, 05 Mar 2020 11:55:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71943/#review219792
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
Lines 239-240 (patched)
<https://reviews.apache.org/r/71943/#comment308012>

    What exactly do you mean here by "must be infinite"? It seems possible that it's not infinite?
Why do we check this for memory but not for CFS quota?
    
    I might suggest that we just set 'mem.limit_in_bytes' to '-1' here the same way we do
for CFS quota, and rely on the operator configuring the cgroup root correctly.



src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp
Lines 282-290 (original), 310-318 (patched)
<https://reviews.apache.org/r/71943/#comment308013>

    Isn't it possible that the memory limit may be lowered multiple times? If so, I think
`setFunctions` would be empty the second time it is lowered?


- Greg Mann


On Feb. 26, 2020, 12:16 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71943/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2020, 12:16 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10048
>     https://issues.apache.org/jira/browse/MESOS-10048
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set container's `memory.limit_in_bytes` to its memory limit.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.hpp 27d88e91fb784179effd54781f84000fe85c13eb

>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 0896d37761a11f55ba4b866d235c3bd2b79dcfba

> 
> 
> Diff: https://reviews.apache.org/r/71943/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message