mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Date Tue, 03 Mar 2020 20:14:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72187/
-----------------------------------------------------------

(Updated March 3, 2020, 8:14 p.m.)


Review request for mesos, Andrei Budnik and Benjamin Mahler.


Changes
-------

Moved as a brace-init-list into `createObjectApprovers(...)` to avoid non-pod global static
and other initializer_list lifetime issues.


Bugs: MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10056


Repository: mesos


Description
-------

Fixed build on platforms not treating initializer_list<enum> as literal.


Diffs (updated)
-----

  src/master/framework.cpp 7e46469dc727ea6f38ca6331b649b3c80e343171 


Diff: https://reviews.apache.org/r/72187/diff/2/

Changes: https://reviews.apache.org/r/72187/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message