mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Date Tue, 03 Mar 2020 19:01:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72122/#review219740
-----------------------------------------------------------



Bad review!

Reviews applied: [72122, 71966, 71965, 72121]

Error:
2020-03-03 19:01:03 URL:https://reviews.apache.org/r/71965/diff/raw/ [12043/12043] -> "71965.patch"
[1]
error: patch failed: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp:818
error: src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp: patch does not apply

- Mesos Reviewbot


On Feb. 12, 2020, 3:48 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72122/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2020, 3:48 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch modifies `cgroups::create` function to call
> `cloneCpusetCpusMems` for all absent nested cgroups along
> the path to a cgroup that is accepted as an argument of this function.
> For instance, if `cgroups::create` is called to create three
> non-existent cgroups recursively for the path `/a/b/c`, then
> `cloneCpusetCpusMems` is called to clone both `cpuset.cpus` and
> `cpuset.mems` for `/a` from its parent, then `/a/b` from `/a`,
> and so on down the path.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 73646c9eb39948192acedb67e3d2fb13acb14b30 
> 
> 
> Diff: https://reviews.apache.org/r/72122/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message