mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Date Tue, 03 Mar 2020 15:36:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72185/#review219737
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/role_tests.cpp
Line 494 (original), 494 (patched)
<https://reviews.apache.org/r/72185/#comment307940>

    should we add a TODO here saying why it's disabled and that we'd like to enable it?


- Benjamin Mahler


On March 3, 2020, 2:04 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72185/
> -----------------------------------------------------------
> 
> (Updated March 3, 2020, 2:04 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch temporarily disables this test on Windows due to the need
> to use "posix" launcher in the current implementation of the test.
> 
> 
> Diffs
> -----
> 
>   src/tests/role_tests.cpp fb8122b4ca5a158e61a100bd91ec6fd752a06bab 
> 
> 
> Diff: https://reviews.apache.org/r/72185/diff/1/
> 
> 
> Testing
> -------
> 
> `./bin/mesos-tests.sh --gtest_filter="*RoleTest.RolesEndpointContainsConsumedQuota*"
--gtest_break_on_failure --verbose` on Linux.
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message