mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71858: Set resource limits when launching executor container.
Date Tue, 03 Mar 2020 14:26:20 GMT


> On Feb. 29, 2020, 1:38 a.m., Greg Mann wrote:
> > src/slave/slave.cpp
> > Lines 3201-3204 (original), 3285-3291 (patched)
> > <https://reviews.apache.org/r/71858/diff/10/?file=2212019#file2212019line3285>
> >
> >     So it looks like here, we will only set limits for the executor if they are
explicitly set for its tasks. This is different than what we intend to do for task containers,
since in that case we will set their limits equal to their requests if `share_cgroups==true`
(modulo the value of the agent's `--cgroups_enable_cfs` flag).
> >     
> >     Should we do the same for the executor container?

> since in that case we will set their limits equal to their requests if share_cgroups==true
(modulo the value of the agent's --cgroups_enable_cfs flag).

Did you mean `share_cgroups` is true or false? I think if it is true, we will neither set
soft limit nor the hard limit for the individual task since it does not have its own cgroups.


I think we already do the similar for the executor container, I mean if no tasks have limits
set, we will not set executor limit here, but we will always set executor resource requests
to the sum of all its task's resource requests:
```
*executorInfo_.mutable_resources() =
      Resources(executorInfo.resources()) + totalTaskResources;
```
So in CPU subsystem of cgroup isolator, we will set executor container's CFS quota to its
resource request if `--cgroups_enable_cfs` is true.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71858/#review219692
-----------------------------------------------------------


On Feb. 25, 2020, 9:46 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71858/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2020, 9:46 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10046
>     https://issues.apache.org/jira/browse/MESOS-10046
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set resource limits when launching executor container.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 03279db082bdba23dbfeb2d93081a908e609aec2 
>   src/slave/slave.cpp cce275a504effae7a6b71dd333ce8a300d1ce5be 
> 
> 
> Diff: https://reviews.apache.org/r/71858/diff/10/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message