mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Date Mon, 02 Mar 2020 13:23:33 GMT


> On Feb. 27, 2020, 11:34 p.m., Greg Mann wrote:
> > 3rdparty/stout/include/stout/jsonify.hpp
> > Line 91 (original), 91-96 (patched)
> > <https://reviews.apache.org/r/72162/diff/1/?file=2212014#file2212014line91>
> >
> >     One other option here and elsewhere is to redefine `RAPIDJSON_WRITE_DEFAULT_FLAGS`;
not sure if one or the other is more desirable, WDYT?

Yeah, I agree redefining `RAPIDJSON_WRITE_DEFAULT_FLAGS` is better.


> On Feb. 27, 2020, 11:34 p.m., Greg Mann wrote:
> > 3rdparty/stout/tests/protobuf_tests.cpp
> > Lines 885 (patched)
> > <https://reviews.apache.org/r/72162/diff/1/?file=2212016#file2212016line885>
> >
> >     Does this ordering matter? Can we remove this comment?

Yeah, it matters, otherwise this test will fail because the keys in the output of `stringify(object)`
are in alphabetical order.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72162/#review219673
-----------------------------------------------------------


On March 2, 2020, 2:31 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72162/
> -----------------------------------------------------------
> 
> (Updated March 2, 2020, 2:31 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Andrei Sekretenko, Benjamin Mahler, and Greg
Mann.
> 
> 
> Bugs: MESOS-10064
>     https://issues.apache.org/jira/browse/MESOS-10064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/jsonify.hpp 7a239d846de5679e9c2b80aa4e617a72fdeac92c 
>   3rdparty/stout/include/stout/protobuf.hpp fcd91d5ea822612e4b32d157fcbc5f0dedeba823

>   3rdparty/stout/tests/protobuf_tests.cpp 55889dc432a9459965d3dd75052d672828cdea90 
>   3rdparty/stout/tests/protobuf_tests.proto 5e20215fcc69e400358847d0ce943d8c18f2a9e0

> 
> 
> Diff: https://reviews.apache.org/r/72162/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message