mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72161: Added patch for RapidJSON.
Date Mon, 02 Mar 2020 06:27:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72161/
-----------------------------------------------------------

(Updated March 2, 2020, 2:27 p.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Changes
-------

Patched `bool Writer<StringBuffer>::WriteDouble(double d)` as well.


Bugs: MESOS-10064
    https://issues.apache.org/jira/browse/MESOS-10064


Repository: mesos


Description
-------

This commit updates the writer of RapidJSON to write infinite
floating point numbers as "Infinity" and "-Infinity" (i.e.,
with double quotes) rather than Infinity and -Infinity. This
is to ensure the strings converted from JSON objects conform
to the rule defined by Protobuf:
https://developers.google.com/protocol-buffers/docs/proto3#json


Diffs (updated)
-----

  3rdparty/CMakeLists.txt c45d742684ba4b3b4abc57ae0bcb85a879c68bfd 
  3rdparty/rapidjson-1.1.0.patch PRE-CREATION 


Diff: https://reviews.apache.org/r/72161/diff/2/

Changes: https://reviews.apache.org/r/72161/diff/1-2/


Testing
-------


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message