mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Date Mon, 02 Mar 2020 01:56:39 GMT


> On Feb. 26, 2020, 1:23 a.m., Andrei Budnik wrote:
> > 3rdparty/stout/include/stout/protobuf.hpp
> > Lines 549 (patched)
> > <https://reviews.apache.org/r/72162/diff/1/?file=2212015#file2212015line549>
> >
> >     Is `double` infinity a better option here given that `JSON::Number` stores a
value in `double`?

Yeah, I agree!


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72162/#review219657
-----------------------------------------------------------


On Feb. 28, 2020, 1:46 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72162/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2020, 1:46 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Andrei Sekretenko, Benjamin Mahler, and Greg
Mann.
> 
> 
> Bugs: MESOS-10064
>     https://issues.apache.org/jira/browse/MESOS-10064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/jsonify.hpp 7a239d846de5679e9c2b80aa4e617a72fdeac92c 
>   3rdparty/stout/include/stout/protobuf.hpp fcd91d5ea822612e4b32d157fcbc5f0dedeba823

>   3rdparty/stout/tests/protobuf_tests.cpp 55889dc432a9459965d3dd75052d672828cdea90 
>   3rdparty/stout/tests/protobuf_tests.proto 5e20215fcc69e400358847d0ce943d8c18f2a9e0

> 
> 
> Diff: https://reviews.apache.org/r/72162/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message