mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72161: Added patch for RapidJSON.
Date Sun, 01 Mar 2020 01:34:12 GMT


> On Feb. 28, 2020, 12:35 a.m., Greg Mann wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 482-484 (original), 482-487 (patched)
> > <https://reviews.apache.org/r/72161/diff/1/?file=2212006#file2212006line482>
> >
> >     We need to update the autotools build as well right?

It is already handled here: https://github.com/apache/mesos/blob/1.9.0/3rdparty/Makefile.am#L168:L172


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72161/#review219676
-----------------------------------------------------------


On Feb. 25, 2020, 9:07 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72161/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2020, 9:07 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10064
>     https://issues.apache.org/jira/browse/MESOS-10064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit updates the writer of RapidJSON to write infinite
> floating point numbers as "Infinity" and "-Infinity" (i.e.,
> with double quotes) rather than Infinity and -Infinity. This
> is to ensure the strings converted from JSON objects conform
> to the rule defined by Protobuf:
> https://developers.google.com/protocol-buffers/docs/proto3#json
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt c45d742684ba4b3b4abc57ae0bcb85a879c68bfd 
>   3rdparty/rapidjson-1.1.0.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72161/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message