mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] bluezd commented on a change in pull request #353: Hook manager mutex and global variable enhancement.
Date Wed, 25 Mar 2020 03:15:21 GMT
bluezd commented on a change in pull request #353: Hook manager mutex and global variable enhancement.
URL: https://github.com/apache/mesos/pull/353#discussion_r397585853
 
 

 ##########
 File path: src/hook/manager.cpp
 ##########
 @@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
 namespace mesos {
 namespace internal {
 
-static std::mutex mutex;
-static LinkedHashMap<string, Hook*> availableHooks;
+static std::mutex* mutex = new(std::mutex);
+static LinkedHashMap<string, Hook*>* availableHooks = new(LinkedHashMap<string,
Hook*>);
 
 Review comment:
   Thanks for your info, just installed the commit hook and make changes to the code accordingly
per your suggestion.
   
   Could you help reviewing it again ? @bmahler 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message