mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement
Date Tue, 24 Mar 2020 20:03:30 GMT
bmahler commented on a change in pull request #353: hook manager mutex and global variable
enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r397426753
 
 

 ##########
 File path: src/hook/manager.cpp
 ##########
 @@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
 namespace mesos {
 namespace internal {
 
-static std::mutex mutex;
-static LinkedHashMap<string, Hook*> availableHooks;
+static std::mutex* mutex = new(std::mutex);
+static LinkedHashMap<string, Hook*>* availableHooks = new(LinkedHashMap<string,
Hook*>);
 
 Review comment:
   This line is also > 80 characters. Are you using the commit hook? It would catch this
issue:
   
   http://mesos.apache.org/documentation/latest/advanced-contribution/#create-your-patch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message