mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] bmahler commented on issue #353: hook manager mutex and global variable enhancement
Date Tue, 24 Mar 2020 19:57:02 GMT
bmahler commented on issue #353: hook manager mutex and global variable enhancement
URL: https://github.com/apache/mesos/pull/353#issuecomment-603473389
 
 
   @asekretenko these are good questions to be asking, as I also felt this looked a bit strange.
I suspect it's just modeled in the same way that ModuleManager is written which has quite
a bit more to it but is also an all static class with similar static non-POD issues. For unload,
it looks like it is used for testing so I'm not sure how easily it could be removed. At this
point I haven't read through all the module related code enough to be contemplating changing
the design, so I can't write a useful TODO or ticket (but please feel free to if you're interested
in pitching in to clean this up!)
   
   Since @bluezd is a new contributor and was interested in hooks/modules, I looked for some
small tickets for him to get some experience with the contribution process, and so this patch
is just focusing on the trivial work of removing static non-PODs (which we ban) and fixing
some unsafe locking in this code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message