mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72179: Got rid of passing Shared<> into `Subscribers::Subscriber::send(...)`.
Date Fri, 28 Feb 2020 22:30:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72179/#review219703
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Feb. 28, 2020, 9:56 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72179/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2020, 9:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10057
>     https://issues.apache.org/jira/browse/MESOS-10057
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that operator API events are authorized synchronously,
> `Subscribers::Subscriber::send(...)` is no longer deferred,
> and copying arguments of `Subscribers::send()` into `Shared`
> becomes unnecessary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp f3239cd2efdad8a3391878c9e62c771673400372 
>   src/master/master.cpp 3c621e44f15b820c5e4105da1cc19283323ff177 
> 
> 
> Diff: https://reviews.apache.org/r/72179/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message