mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Date Fri, 28 Feb 2020 18:07:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72170/#review219698
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Feb. 28, 2020, 1:09 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72170/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2020, 1:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10056
>     https://issues.apache.org/jira/browse/MESOS-10056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As per MESOS-10056, authorizer is now responsible for keeping
> `ObjectApprover`s valid throughout their lifetime, which might be quite
> expensive for custom authorizer implementations that get permissions
> from an external IAM.
> 
> This test makes sure that ObjectApprovers of a disconnected framework
> are removed.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_authorization_tests.cpp bc8155b97c9078eaa151cc4a3e5bc6ea0d7ac9fa 
> 
> 
> Diff: https://reviews.apache.org/r/72170/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message