mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Date Thu, 27 Feb 2020 15:34:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72162/#review219673
-----------------------------------------------------------




3rdparty/stout/include/stout/jsonify.hpp
Line 91 (original), 91-96 (patched)
<https://reviews.apache.org/r/72162/#comment307883>

    One other option here and elsewhere is to redefine `RAPIDJSON_WRITE_DEFAULT_FLAGS`; not
sure if one or the other is more desirable, WDYT?



3rdparty/stout/tests/protobuf_tests.cpp
Lines 885 (patched)
<https://reviews.apache.org/r/72162/#comment307884>

    Does this ordering matter? Can we remove this comment?



3rdparty/stout/tests/protobuf_tests.cpp
Lines 910-913 (patched)
<https://reviews.apache.org/r/72162/#comment307885>

    Could you verify the contents of the result here as well?


- Greg Mann


On Feb. 25, 2020, 1:26 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72162/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2020, 1:26 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10064
>     https://issues.apache.org/jira/browse/MESOS-10064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/jsonify.hpp 7a239d846de5679e9c2b80aa4e617a72fdeac92c 
>   3rdparty/stout/include/stout/protobuf.hpp fcd91d5ea822612e4b32d157fcbc5f0dedeba823

>   3rdparty/stout/tests/protobuf_tests.cpp 55889dc432a9459965d3dd75052d672828cdea90 
>   3rdparty/stout/tests/protobuf_tests.proto 5e20215fcc69e400358847d0ce943d8c18f2a9e0

> 
> 
> Diff: https://reviews.apache.org/r/72162/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message