mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Date Mon, 24 Feb 2020 16:39:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72158/
-----------------------------------------------------------

(Updated Фев. 24, 2020, 4:39 п.п.)


Review request for mesos, Andrei Sekretenko, Greg Mann, and Qian Zhang.


Bugs: MESOS-10098
    https://issues.apache.org/jira/browse/MESOS-10098


Repository: mesos


Description
-------

This patch fixes the bug when `listenFdsWithName` function returns
an empty set of file descriptors on pre-227 systemd versions when
`domain_socket_location` value is not equals to the "systemd:unknown".
This happens when a user expects a newer version of systemd and
specifies a "systemd/<value taken from FileDescriptorName>", but
the actual systemd version does not support `FileDescriptorName`.
In this case, `LISTEN_FDNAMES` env variable is not specified,
so all socket FDs, which are specified by the `LISTEN_FDS`,
must be used to locate the path to the domain socket.


Diffs (updated)
-----

  src/linux/systemd.hpp ba960009d4e47f253fccfcd0edeedf4e6cdc0dca 
  src/linux/systemd.cpp 9897473115ac0f9809734c109ba412eefd32e59e 
  src/slave/main.cpp c1e65519f4c684dcd608cbd1a67d7f5945161af4 


Diff: https://reviews.apache.org/r/72158/diff/2/

Changes: https://reviews.apache.org/r/72158/diff/1-2/


Testing
-------

internal CI (including CoreOS)


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message