From reviews-return-90899-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Jan 21 23:26:05 2020 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 9B2EF10E2C for ; Tue, 21 Jan 2020 23:26:05 +0000 (UTC) Received: (qmail 98543 invoked by uid 500); 21 Jan 2020 23:26:05 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 98522 invoked by uid 500); 21 Jan 2020 23:26:05 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 98503 invoked by uid 99); 21 Jan 2020 23:26:04 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jan 2020 23:26:04 +0000 Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 40090E00CD; Tue, 21 Jan 2020 23:26:04 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B7512C40128; Tue, 21 Jan 2020 23:26:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1964590268390550475==" MIME-Version: 1.0 Subject: Re: Review Request 72016: Reverted SSL Socket guard against downgrade. From: Greg Mann To: Benjamin Mahler , Greg Mann Cc: Joseph Wu , mesos Date: Tue, 21 Jan 2020 23:26:03 -0000 Message-ID: <20200121232603.56871.50371@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/72016/ X-Sender: Greg Mann X-ReviewBoard-ShipIt: 1 References: <20200116184954.58037.90117@reviews-vm2.apache.org> In-Reply-To: <20200116184954.58037.90117@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============1964590268390550475== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72016/#review219351 ----------------------------------------------------------- Ship it! Ship It! - Greg Mann On Jan. 16, 2020, 6:49 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72016/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2020, 6:49 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10073 > https://issues.apache.org/jira/browse/MESOS-10073 > > > Repository: mesos > > > Description > ------- > > This reverts commit 34bac34419ebec8441e69d3a5684381468352399. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.cpp b2dd2feec41c80c8226b4478e8e6b0bfcb38fcef > 3rdparty/libprocess/src/tests/ssl_tests.cpp a6563fb50e4356e51e958d262979b7ed7221f028 > > > Diff: https://reviews.apache.org/r/72016/diff/1/ > > > Testing > ------- > > make check (two tests now fail) > > > Thanks, > > Joseph Wu > > --===============1964590268390550475==--