mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 72029: Changed termination logic of the default executor.
Date Wed, 29 Jan 2020 21:28:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72029/
-----------------------------------------------------------

(Updated Янв. 29, 2020, 9:28 п.п.)


Review request for mesos, Andrei Sekretenko, Greg Mann, Qian Zhang, and Vinod Kone.


Summary (updated)
-----------------

Changed termination logic of the default executor.


Bugs: MESOS-8537
    https://issues.apache.org/jira/browse/MESOS-8537


Repository: mesos


Description (updated)
-------

Previously, the default executor terminated itself after all containers
had terminated. This could lead to termination of the executor before
processing of a terminal status update by the agent. In order
to mitigate this issue, the executor slept for one second to give a
chance to send all status updates and receive all status update
acknowledgements before terminating itself. This might have led to
various race conditions in some circumstances (e.g., on a slow host).
This patch terminates the default executor if all status updates have
been acknowledged by the agent and no running containers left.
Also, this patch increases the timeout from one second to one minute
for fail-safety.


Diffs (updated)
-----

  src/launcher/default_executor.cpp 4369fd0052b2e8496ba63606fa57e17d881ea52c 


Diff: https://reviews.apache.org/r/72029/diff/3/

Changes: https://reviews.apache.org/r/72029/diff/2-3/


Testing
-------

internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message