mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <>
Subject Re: Review Request 72055: Changed termination logic of the Docker executor.
Date Wed, 29 Jan 2020 16:23:52 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Янв. 29, 2020, 4:23 п.п.)

Review request for mesos, Andrei Sekretenko, Greg Mann, Qian Zhang, and Vinod Kone.


addressed Qian's comments

Summary (updated)

Changed termination logic of the Docker executor.

Bugs: MESOS-9847

Repository: mesos

Description (updated)

Previously, the Docker executor terminated itself after a task's
container had terminated. This could lead to termination of the
executor before processing of a terminal status update by the agent.
In order to mitigate this issue, the executor slept for one second to
give a chance to send all status updates and receive all status update
acknowledgments before terminating itself. This might have led to
various race conditions in some circumstances (e.g., on a slow host).
This patch terminates the Docker executor after receiving a terminal
status update acknowledgment. Also, this patch increases the timeout
from one second to one minute for fail-safety.

Diffs (updated)

  src/docker/executor.cpp 132f42bfa42c846fc5dc40f7763aa0b5d12a7798 
  src/exec/exec.cpp 69e5e24b248c7c913421de5e42713c34fd79ad46 




internal CI


Andrei Budnik

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message