mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 72014: SSL Socket: Moved accept callback logic into protected function.
Date Tue, 21 Jan 2020 23:21:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72014/#review219350
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Jan. 16, 2020, 6:49 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72014/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2020, 6:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10073
>     https://issues.apache.org/jira/browse/MESOS-10073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To support SSL downgrades, this logic will need to be called
> from two potential callsites.
> 
> Also fixes a slight typo in a comment within the moved code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/ssl/openssl_socket.hpp 2d0259d5fa20140c61bb2c699b69214d3e436e16

>   3rdparty/libprocess/src/ssl/openssl_socket.cpp 74f9fe2443efa37c0b6c7f77120b140f5ac0b53b

> 
> 
> Diff: https://reviews.apache.org/r/72014/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message