mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 72033: Decoupled detection of generated executors from Mesos install location.
Date Tue, 21 Jan 2020 15:39:40 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 21, 2020, 4:39 p.m.)

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.

Bugs: MESOS-10084

Repository: mesos

Description (updated)

We previously were detecting executors generated for command tasks by
checking whether their command matched the full path of
`mesos-executor`.  This approach can lead to misdetection if e.g.,
during an upgrade a new installation location is choosen.

This patch adjusts the heuristic by now only relying on the fact that
the executor command should end in `mesos-executor`. In order to cut
down on false positives we now additionally check that the executor name
looks similar to the ones we generate for command tasks.

Diffs (updated)

  src/slave/slave.cpp 0005971717f5b90da368b45caad8e209ada95fa5 




`make check`


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message