mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72035: Remembered whether an executor was agent-generated.
Date Tue, 21 Jan 2020 13:40:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72035/#review219342
-----------------------------------------------------------




src/slave/slave.cpp
Lines 10625 (patched)
<https://reviews.apache.org/r/72035/#comment307486>

    Can you avoid spliting initialization of  `isGeneratedForCommandTask_` and just fully
initialize it here? 
    After that, it should also be possible to make it `const`.
    
    Btw, it might make sense to move the workaround logic into `ExecutorState::recover(...)`
so that we don't have Option in the code.


- Andrei Sekretenko


On Jan. 21, 2020, 12:20 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72035/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2020, 12:20 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10084
>     https://issues.apache.org/jira/browse/MESOS-10084
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds code to pass on whether was generated in the agent from
> the point where the executor is generated to the point where we create
> an actual `slave::Executor` instance. This allows us to persist this
> information in the executor state.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 3d191dcbdd58e851ad5e86fbb01a890407409c64 
>   src/slave/slave.cpp 0005971717f5b90da368b45caad8e209ada95fa5 
>   src/tests/mock_slave.hpp eb31a0f93d21ef859684c26a99effde08348ead6 
>   src/tests/mock_slave.cpp 4940285b183a9513701e616e7d7523801daf113b 
> 
> 
> Diff: https://reviews.apache.org/r/72035/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message