mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 72029: Changed logic of termination of the default executor.
Date Mon, 20 Jan 2020 18:40:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72029/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko, Greg Mann, Qian Zhang, and Vinod Kone.


Repository: mesos


Description
-------

Previously, the default executor terminated itself after all containers
had terminated. This could lead to termination of the executor before
receiving all status update acknowledgements from the agent. In order
to mitigate this issue, the executor slept for one second to give a
chance to send all status updates and receive all status update
acknowledgements before terminating itself. This might have led to
various race conditions in some circumstances (e.g., on a slow host).
This patch terminates the default executor if and only if all status
updates have been acknowledged by the agent and no running containers
left. Also, this patch removes the unnecessary call of `sleep`.


Diffs
-----

  src/launcher/default_executor.cpp 4369fd0052b2e8496ba63606fa57e17d881ea52c 


Diff: https://reviews.apache.org/r/72029/diff/1/


Testing
-------

internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message