mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72011: Removed unintentional copies of for loop iteration variables.
Date Fri, 17 Jan 2020 10:59:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72011/#review219320
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Sekretenko


On Jan. 16, 2020, 2:01 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72011/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2020, 2:01 p.m.)
> 
> 
> Review request for mesos and Andrei Sekretenko.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unintentional copies of for loop iteration variables.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp d628bb3443b32acac38e29a15a49be688b35b8b3 
>   src/slave/container_loggers/lib_logrotate.cpp 3ecd83ef42a5bff9ec082024bdabaf6cb4a50de0

>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 4afef7f75092067caac35459805d670a9651afa0

>   src/slave/gc.cpp 450bbef66e317a403d566bb0ac5ccf5fb0d2329e 
>   src/tests/sorter_tests.cpp 472691d1aba9d476bf0cf35ca82106d880cdc415 
> 
> 
> Diff: https://reviews.apache.org/r/72011/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message