mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 72017: SSL Socket: Added downgrade support.
Date Thu, 16 Jan 2020 18:49:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72017/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Greg Mann.


Bugs: MESOS-10073
    https://issues.apache.org/jira/browse/MESOS-10073


Repository: mesos


Description
-------

This adds downgrade support, in the same fashion that the
Libevent SSL socket does (and copies a good chunk of the code
from there too).  To account for Windows not having `io::poll`,
a slight hack is taken to check for readable bytes.


Diffs
-----

  3rdparty/libprocess/src/ssl/openssl_socket.cpp 74f9fe2443efa37c0b6c7f77120b140f5ac0b53b



Diff: https://reviews.apache.org/r/72017/diff/1/


Testing
-------

make check (tests enabled with the previous review now pass)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message