mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Date Thu, 16 Jan 2020 18:04:32 GMT


> On Янв. 13, 2020, 6:53 д.п., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 315 (patched)
> > <https://reviews.apache.org/r/71966/diff/1/?file=2199233#file2199233line316>
> >
> >     Shouldn't it be a warning instead?

I copied it from the Linux Launcher: https://github.com/apache/mesos/blob/1e75e3875a14e5d358a4f2f278831057bf689267/src/slave/containerizer/mesos/linux_launcher.cpp#L329-L331


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71966/#review219229
-----------------------------------------------------------


On Янв. 7, 2020, 5:06 п.п., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71966/
> -----------------------------------------------------------
> 
> (Updated Янв. 7, 2020, 5:06 п.п.)
> 
> 
> Review request for mesos, Greg Mann and Qian Zhang.
> 
> 
> Bugs: MESOS-10079
>     https://issues.apache.org/jira/browse/MESOS-10079
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch enables recovery for nested cgroups and implements
> the detection of orphaned nested cgroups.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 4bd3d6dad37dee031660c15e957cc36f63e21fcb

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp b12b73d8e0161d448075378765e77867521de04e

> 
> 
> Diff: https://reviews.apache.org/r/71966/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message