mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.
Date Thu, 16 Jan 2020 13:54:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72002/#review219303
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Sekretenko


On Jan. 16, 2020, 1:51 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72002/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2020, 1:51 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10084
>     https://issues.apache.org/jira/browse/MESOS-10084
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For command tasks the agent will generate an `ExecutorInfo` which was
> previously detected with a path-based heuristic. If the installation
> location of Mesos changes, e.g., in an upgrade this can lead to
> misdetections of generated executors.
> 
> The flag added in this patch will be set and persisted in a follow-up
> patch which will allow for a more stable solution.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto b0f590545df720df644d049e9d8f1e81bdbe814c 
>   include/mesos/v1/mesos.proto 53a7b9bc6190d826868a1633c11c9a0ecf9acf0a 
>   src/master/validation.cpp d628bb3443b32acac38e29a15a49be688b35b8b3 
> 
> 
> Diff: https://reviews.apache.org/r/72002/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message