mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Date Wed, 15 Jan 2020 11:25:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72003/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Bugs: MESOS-10084
    https://issues.apache.org/jira/browse/MESOS-10084


Repository: mesos


Description
-------

This patch modifies the agent code so it uses
`ExecutorInfo::generated_by_agent` instead of the previous heuristic to
detect agent-generated executors for command tasks. For that we add
recovery logic for upgrade scenarios to inject a correct value for
recovered executors, and set the appropriate value for newly created
executors.


Diffs
-----

  src/slave/slave.hpp 3d191dcbdd58e851ad5e86fbb01a890407409c64 
  src/slave/slave.cpp 0005971717f5b90da368b45caad8e209ada95fa5 


Diff: https://reviews.apache.org/r/72003/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message