mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Date Tue, 14 Jan 2020 19:08:55 GMT


> On Jan. 14, 2020, 12:52 p.m., Andrei Sekretenko wrote:
> > src/master/master.hpp
> > Lines 1388-1417 (patched)
> > <https://reviews.apache.org/r/71978/diff/1/?file=2201049#file2201049line1388>
> >
> >     Consider making all those `jsonify/serialize` methods (except for `*getState`
private). 
> >     
> >     This isn't critical as this class holds almost no state, but they are not really
intended for external use, right?

I'll add a TODO, originally I had them as only declared in the .cpp file, but for now they
need to be shared with the SUBSCRIBE code.


> On Jan. 14, 2020, 12:52 p.m., Andrei Sekretenko wrote:
> > src/master/readonly_handler.cpp
> > Lines 1669 (patched)
> > <https://reviews.apache.org/r/71978/diff/1/?file=2201050#file2201050line1669>
> >
> >     That's 81 characters - did this pass through the pre-commit hooks?

:O will look into this


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71978/#review219252
-----------------------------------------------------------


On Jan. 9, 2020, 5:48 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71978/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2020, 5:48 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Greg Mann.
> 
> 
> Bugs: MESOS-9497
>     https://issues.apache.org/jira/browse/MESOS-9497
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Using the same approach taken for the v0 read-only endpoints,
> this enables parallel reads for the GET_* v1 master calls.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 16dbed3aad7aeac7f45eb44ffc98cb9df6546aff 
>   src/master/master.hpp c9d417c23981a3908b419ce70cdf9a0096e37c17 
>   src/master/readonly_handler.cpp 500ce3f6a0f3afc3193586020fa5c253e4c6801c 
>   src/tests/master_load_tests.cpp ac16fe744ec2a8d4b4af005b91a5560f0b2f3ef3 
> 
> 
> Diff: https://reviews.apache.org/r/71978/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message