mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 71986: Removed redundant calls to `c_str` flagged by mesos-tidy.
Date Mon, 13 Jan 2020 10:10:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71986/#review219234
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On Jan. 13, 2020, 9:49 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71986/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2020, 9:49 a.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These calls were flagged by the upstream
> `readability-redundant-string-cstr` check.
> 
> 
> Diffs
> -----
> 
>   src/linux/systemd.cpp d9cb5662cbf8e4d3531518af8bb633d9bb12d038 
> 
> 
> Diff: https://reviews.apache.org/r/71986/diff/1/
> 
> 
> Testing
> -------
> 
> confirmed that `clang-tidy` does not report anything from these lines anymore
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message