mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 71985: Properly initialized dummy variable.
Date Mon, 13 Jan 2020 10:09:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71985/#review219233
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On Jan. 13, 2020, 9:48 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71985/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2020, 9:48 a.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since `Try` does not have a default constructor we need to provide a
> dummy value.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp 9e40743a9d379d5b1ff9f97372826d4296167ce3 
> 
> 
> Diff: https://reviews.apache.org/r/71985/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` on macos
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message